Conversation
Merged
There was a problem hiding this comment.
Pull request overview
This PR introduces automatic injection of extern specifications for standard library functions in Thrust, a verification tool for Rust. Instead of hardcoding specifications for specific functions like Box::new and std::mem::swap, the PR adds a comprehensive std.rs file containing specifications for common std library functions (Option, Result, Box, mem operations, and i32 methods) that gets automatically injected into the user's code during compilation.
Key changes:
- New
std.rsfile with extern specifications for Option, Result, Box, mem, and i32 methods - Code injection mechanism in
main.rsto parse and inject std.rs into the AST - Type parameter substitution infrastructure in
rty.rsto handle generic specifications correctly
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| std.rs | New file containing extern specifications for standard library functions (Option, Result, Box, mem, i32) |
| src/main.rs | Adds after_crate_root_parsing callback to inject std.rs into the parsed AST |
| src/rty.rs | Implements type parameter substitution in sorts, formulas, terms, and atoms to support generic extern specs |
| src/analyze/basic_block.rs | Removes hardcoded handling of Box::new and mem::swap, now handled via injected specs |
| src/refine/template.rs | Adjusts template building logic for parameter refinements |
| src/analyze/local_def.rs | Filters extern spec target extraction to only Fn and AssocFn def kinds |
| src/analyze.rs | Inlines datatype symbol name construction for enum variants |
| src/chc.rs | Adds args_mut() accessor to DatatypeSort |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.